Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add property to customize universe domain in Pub/Sub #3348

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add property to customize universe domain in Pub/Sub #3348

wants to merge 5 commits into from

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Oct 28, 2024 •
edited
Loading

Notable Changes:

  • Adds subscription-specific property for universe domain to customize Subscriber
  • Adds global subscriber property for universe domain. In terms of priority. The subscription-specific property takes precedence if both global and subscription-specific properties are set. If subscription-specific configuration is not set then the global configuration is picked.
  • Adds global publisher property for universe domain to customize Publisher.

Verified behavior manually in separate test plan document.

@mpeddada1 mpeddada1 marked this pull request as ready for review October 29, 2024 15:43
@mpeddada1 mpeddada1 requested a review from a team as a code owner October 29, 2024 15:43
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
54.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 Awaiting requested review from blakeli0

@burkedavison burkedavison Awaiting requested review from burkedavison

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mpeddada1